Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Some updates to GitHub Actions setup #583

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[CI] Some updates to GitHub Actions setup #583

merged 1 commit into from
Dec 9, 2024

Conversation

giordano
Copy link
Member

@giordano giordano commented Dec 8, 2024 •
edited
Loading

  • Install dependabot
  • Update various external workflows
  • Use julia-actions/cache instead of actions/cache

@giordano
[CI] Some updates to GitHub Actions setup
67ee7e6 
* Install dependabot
* Update various external workflows
* Use `julia-actions/setup-julia` instead of `actions/cache`
@giordano giordano requested a review from DilumAluthge December 8, 2024 20:40
@DilumAluthge
Copy link
Member

  • Use julia-actions/setup-julia instead of actions/cache

Presumably this should say julia-actions/cache instead of julia-actions/setup-julia?

@giordano giordano enabled auto-merge December 8, 2024 20:46
@giordano giordano added this pull request to the merge queue Dec 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 8, 2024
@giordano
Copy link
Member Author

giordano commented Dec 8, 2024

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks

Well, the job is still running.....

@DilumAluthge DilumAluthge added this pull request to the merge queue Dec 9, 2024
Merged via the queue into JuliaRegistries:master with commit a659148 Dec 9, 2024
11 checks passed
@DilumAluthge
Copy link
Member

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks

Well, the job is still running.....

This usually (in my experience) means that the GitHub Merge Queue settings (which are inside the branch protection settings for the master branch) needed to be edited; specifically, the Merge Queue timeout needs to be increased. This is the setting that is labeled as follows:

Status check timeout
Time (in minutes) a required status check must report a conclusion within to not be considered failed.
Consider check failed after:

Currently, that setting is at 120 minutes. I think 120 is sufficient for most cases, so I'll leave it unmodified for now. But if we keep seeing this error in the future, then we can increase it from 120 to something higher.

@giordano giordano deleted the mg/gha branch December 9, 2024 08:41
@ericphanson
Copy link
Member

I think 120 is insufficient, since our integration tests already take over an hour, and they have concurrency limit 1. What happened in this case was the integration tests were running for #582, and shortly after they started we added this PR to merge queue. After an hour, #582 was merged, and the integration tests started running here. Then we hit the 120 minute limit, then after that this PR's integration tests finished.

Since our integration tests take so long and can't run in parallel, I think 120 is too low, and it should be 240+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge DilumAluthge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giordano @DilumAluthge @ericphanson