Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JuliaTagBot is not opening new issue to comment on for triggering the repositories TagBot action #382

Open
anchal-physics opened this issue Jan 27, 2025 · 3 comments

Comments

@anchal-physics
Copy link

Affected Repositories

https://github.com/ProjectTorreyPines/IMASggd.jl

https://github.com/ProjectTorreyPines/SOLPS2imas.jl

Action setup

Both repositories are using reusable workflow definition stored in https://github.com/ProjectTorreyPines/GitHubActionsWorkflows/blob/master/.github/workflows/tag_bot.yml

Note that this reusable workflow uses the same file as described on README.md but I renamed the file to tag_bot.yml to match filename case with other files.

Description of issue

First I tried this in IMASggd while registering 2.0.1 . The registration went through fine but the TagBot did not get triggered. No issue was created and thus no comment was made by JulaTagBot. I thought that maybe the issue is that JuliaTagBot is looking for a TagBot.yml file in the workflow directory and since I changed the name of the file, it could not verify if TagBot action is active or not (although it was visible as TagBot actions in list of available actions in GitHub webpage). Then, I first tried to run the workflow manually to make sure everything else is fine. And it is. The workflow ran fine and generated the new tag.

So to test the 'file name not matching' hypothesis, in another repo, SOLPS2imas, where I was also releasing a new version, I added TagBot with the filename as TagBot.yml but I face the same issue as before. No new issue was opened by JuliaTagBot and no comment was made because of which the action never triggered.

Not sure what is wrong. Should I open a new issue called "TagBot trigger issue" and close it and hope JuliaTagBot will be able to write comments on it in future?

Originally posted by @anchal-physics in #253

@DilumAluthge
Copy link
Member

From this log (https://github.com/JuliaRegistries/General/actions/runs/12960528186/job/36154514185):

[ Info: Processing pull request 123693
[ Info: Processing version v2.0.1 of ProjectTorreyPines/IMASggd.jl
[ Info: TagBot is not enabled on ProjectTorreyPines/IMASggd.jl

The basic problem here is that TagBotTriggers doesn't work if you are using reusable workflows.

You need to actually have the text JuliaRegistries/TagBot in a file matching .github/workflows/*.yml.

@anchal-physics
Copy link
Author

Aha, I knew it has some condition like that. Can I just place JuliaRegistries/TagBot in a comment in the calling action file or does it have to be readable by a yaml parser?

@DilumAluthge
Copy link
Member

anchal-physics added a commit to ProjectTorreyPines/IMASggd.jl that referenced this issue Jan 27, 2025
JuliaTagBot requires one of the workflow files to have text
JuliaRegistries/TagBot to makesure it is being called. Since we are
using reusable workflows, this text is not mentioned in the calling
action file. Thus added a comment that has this text in it.

See JuliaRegistries/TagBot#382 (comment)
for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants