Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No exception/error raised for negative logarithm #128

Open
DanielDoehring opened this issue Dec 8, 2023 · 3 comments
Open

No exception/error raised for negative logarithm #128

DanielDoehring opened this issue Dec 8, 2023 · 3 comments

Comments

@DanielDoehring
Copy link

DanielDoehring commented Dec 8, 2023

It is a bit tough for me to provide a MWE showcasing this behaviour, but you can reproduce this using my branch forked from Trixi.jl.

Then, execute the example https://github.com/DanielDoehring/Trixi.jl/blob/MultiThreadedNegativeLog/examples/tree_2d_dgsem/elixir_mhd_rotor_reproducibility.jl

with one and 16 threads. You should observe that the version with 1 thread crashes as expected, but for the multi-threaded version no error is raised (in contrast to the built-in Julia threads). See also the discussion in the corresponding issue in the Trixi.jl repository.

@DanielDoehring DanielDoehring changed the title No exception raised for negative logarithm No exception/error raised for negative logarithm Dec 8, 2023
@chriselrod
Copy link
Member

Presumably caused by:
JuliaSIMD/ThreadingUtilities.jl@290f4a2
I wanted cleaner JET reports.

@DanielDoehring
Copy link
Author

Ok, I will check if this behaviour still occurs with v0.5.1 of ThreadingUtilities.

@DanielDoehring
Copy link
Author

By switching to v0.5.1 I receive the report that the task failed (which is sufficient for me) but the program still (somehow) continues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants