Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests with the option warm-start #959

Open
amontoison opened this issue Feb 15, 2025 · 1 comment
Open

Add more tests with the option warm-start #959

amontoison opened this issue Feb 15, 2025 · 1 comment
Assignees

Comments

@amontoison
Copy link
Member

It seems that in some corner cases, the correct solution is not returned.
If x0 is the exact solution of Ax = b, it's possible that I return x = 0 but the residual of the shifted system is zero.

@amontoison
Copy link
Member Author

amontoison commented Feb 15, 2025

I need to fix almost all methods...
The good news is that TriLQR can handle the exact solution with warm-start 😛
TriLQR is not checking if the initial residual is 0.

Test Summary:           | Pass  Fail  Total  Time
warm-start              |  108    50    158  3.4s
  Data Type: Float64    |   54    25     79  0.2s
    bilqr               |    4     2      6  0.0s
    trilqr              |    6            6  0.0s
    tricg               |    2     2      4  0.0s
    trimr               |    2     1      3  0.0s
    gpmr                |    2     1      3  0.0s
    minres_qlp          |    2     1      3  0.0s
    symmlq              |    2     1      3  0.0s
    cg                  |    2     1      3  0.0s
    cr                  |    2     1      3  0.0s
    car                 |    2     1      3  0.0s
    cg_lanczos          |    2     1      3  0.0s
    minres              |    2     1      3  0.0s
    minares             |    2     1      3  0.0s
    diom                |    2     1      3  0.0s
    dqgmres             |    2     1      3  0.0s
    fom                 |    2     1      3  0.0s
    gmres               |    2     1      3  0.0s
    fgmres              |    2     1      3  0.0s
    bicgstab            |    2     1      3  0.0s
    cgs                 |    2     1      3  0.0s
    bilq                |    2     1      3  0.0s
    qmr                 |    2     1      3  0.0s
    usymlq              |    2     1      3  0.0s
    usymqr              |    2     1      3  0.0s
  Data Type: ComplexF64 |   54    25     79  3.2s
    bilqr               |    4     2      6  0.0s
    trilqr              |    6            6  0.0s
    tricg               |    2     2      4  0.9s
    trimr               |    2     1      3  2.1s
    gpmr                |    2     1      3  0.0s
    minres_qlp          |    2     1      3  0.0s
    symmlq              |    2     1      3  0.0s
    cg                  |    2     1      3  0.0s
    cr                  |    2     1      3  0.0s
    car                 |    2     1      3  0.0s
    cg_lanczos          |    2     1      3  0.0s
    minres              |    2     1      3  0.0s
    minares             |    2     1      3  0.0s
    diom                |    2     1      3  0.0s
    dqgmres             |    2     1      3  0.0s
    fom                 |    2     1      3  0.0s
    gmres               |    2     1      3  0.0s
    fgmres              |    2     1      3  0.0s
    bicgstab            |    2     1      3  0.0s
    cgs                 |    2     1      3  0.0s
    bilq                |    2     1      3  0.0s
    qmr                 |    2     1      3  0.0s
    usymlq              |    2     1      3  0.0s
    usymqr              |    2     1      3  0.0s
ERROR: LoadError: Some tests did not pass: 108 passed, 50 failed, 0 errored, 0 broken.
in expression starting at /home/alexis/Bureau/git/Krylov.jl/test/test_warm_start.jl:502

@amontoison amontoison changed the title All more tests with the option warm-start Add more tests with the option warm-start Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant