Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normest broken for non-square matrices #362

Open
njericha opened this issue Jan 30, 2025 · 1 comment
Open

normest broken for non-square matrices #362

njericha opened this issue Jan 30, 2025 · 1 comment

Comments

@njericha
Copy link

I tried using normest for a non-square matrix and was prompted with a dimension error. I believe in this line, the n should be changed to an m since the operator S has size (m,n).

LinearOperators.jl/src/utilities.jl

Line 39 in 0295c20

Sx = zeros(eltype(S), n)

@dpo
Copy link
Member

dpo commented Jan 30, 2025

Yes, thanks. Would you mind submitting a PR?

njericha added a commit to njericha/LinearOperators.jl that referenced this issue Jan 31, 2025
@njericha
fix normest not working on rectangular matrices
2210767 
See JuliaSmoothOptimizers#362
@njericha njericha mentioned this issue Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpo @njericha