Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations plan "Convert Grid to BlockGrid" not actually working #219

Open
julian-gallo-nexer opened this issue Sep 28, 2023 · 0 comments
Open
Labels
help wanted Extra attention is needed

Comments

@julian-gallo-nexer
Copy link

julian-gallo-nexer commented Sep 28, 2023

I have been doing some experiments with usync migration, first ones consisted on simple project with starter kit and a simple DTGE, out of the box it has 3 migration plans in the UI:

  • Convert Grid to BlockGrid
  • Convert Nested content to BlockLists
  • Convert to Nested Content to BlockLists and Grid to BlockGrid

So I figure out that using Grid to Block Grid would work, but it didn't, it only migrated with complete profile "Convert to Nested Content to BlockLists and Grid to BlockGrid"

I went in deeper investigations for my project which uses lot of custom DTGE and I might not want actually to convert nested content yet and I see the root of that issue

In this class:

{ UmbConstants.PropertyEditors.Aliases.NestedContent, nameof(NestedToBlockListMigrator) },

What currently is:
UmbConstants.PropertyEditors.Aliases.NestedContent, nameof(NestedToBlockListMigrator)

What should be:
UmbConstants.PropertyEditors.Aliases.Grid, nameof(GridToBlockGridMigrator)

I can raise a PR for sure but I wanted to know if this is intented this way or is an issue in fact

@KevinJump KevinJump added the help wanted Extra attention is needed label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants