-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically document entity / relationship schema in j1-integration document
#612
Comments
Today, we produce a table like:
Given the following schema: export const EC2Entities = {
AWS_VPC: {
resourceName: 'AWS VPC',
_type: 'aws_vpc',
_class: ['Network'],
schema: {
additionalProperties: true,
properties: {
_type: { const: 'aws_vpc' },
displayName: { type: 'string' },
vpcId: { type: 'string' },
region: { type: 'string' },
id: { type: 'string' },
awsAccountId: { type: 'string' },
CIDR: { type: 'string' },
webLink: { type: 'string' },
},
required: ['vpcId', 'region', 'displayName', 'CIDR', 'webLink', 'name'],
},
},
}; How should our docs look? Option 1 - Add properties to Data ModelEntitiesThe following entities are created:
Option 2 - Add new section (or new document) with entity properties Data ModelEntitiesThe following entities are created:
Entity PropertiesEntities have the following properties: aws_vpc
RelationshipsThe following relationships are created:
Mapped RelationshipsThe following mapped relationships are created:
|
We will definitely want to produce new documentation pages for entities and relationships respectively. In fact, we may even want to consider producing a document for each entity and one document for relationships. Some entities have many properties and it would cause super slow rendering in a web app if we produced one massive page. In the case of a document per entity, we could have a "glossary" page that would link out to the respective documents. |
OK. So maybe each row in the table links to another MD document or something? |
@ndowmon Yes. Would be excellent. |
and once it reaches ZD / vanilla / etc, it all blows up. |
@ndowmon Definitely will require some custom instrumentation to support on our publicly facing documentation website, but this is a step in the right direction and will serve as our baseline. |
Should this auto-documentation automatically pull any schemas from the My hunch is no. We should strongly encourage that developers enumerate every property they're adding to this entity, even if it is already enforced by the data model. |
Would love to see a ticket in the SDK describing this!
Originally posted by @austinkelleher in #611 (comment)
The text was updated successfully, but these errors were encountered: