Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect device_class for D230 doorbell battery sensor. #571

Closed
Spamfast opened this issue May 14, 2024 · 2 comments
Closed

Incorrect device_class for D230 doorbell battery sensor. #571

Spamfast opened this issue May 14, 2024 · 2 comments
Labels
Fixed Bug has been fixed.

Comments

@Spamfast
Copy link

Description

I have a Tapo D230 doorbell connected via an H200 hub. The integration is exposing all its attributes correctly except that the sensor.xxxx_battery battery level percentage is being given a device class of 'mdi:battery' and not 'battery' and so is not showing up in battery-filtered cards, automations etc. For now I've corrected it in my customization YAML file.

Reproduction Steps

  1. Install the Tapo app on Android device.
  2. Add the H200 hub.
  3. Add the D230 doorbell.
  4. Install Tapo: Cameras Control from HACS.
  5. Add the hub to the integration - doorbell auto-detected and configured.
  6. Check in Developer Tools->States -- device_class shows as 'mdi:battery'.

Expected behavior

The device class should be the string 'battery' not 'mdi:battery'.

If applicable, add error logs.

No response

Device Firmware

D230 1.1.14, H200 1.3.1

Integration Version

5.4.18

Using stream component

Yes

Does camera work via official integrations?

Yes

Camera has all attributes filled out in developer tools

Yes

HASS Environment

Vanilla HAOS image on x86_64 PC.

Search for similar issues

Yes

Additional information

Core 2024.5.3, supervisor 2024.05.1, OS 12.3, frontent 20240501.1.
@Spamfast Spamfast changed the title Incorrect device_class for D230 doorbell. Incorrect device_class for D230 doorbell battery sensor. Jun 12, 2024
@Spamfast
Copy link
Author

Spamfast commented Jun 12, 2024 •
edited
Loading

Problem is a one-liner in the TapoBatterySensor class constructor where it's setting the device_class argument instead of the icon argument in the base class constructor call.

HomeAssistant-Tapo-Control/custom_components/tapo_control/sensor.py

Line 215 in 88949f3

"mdi:battery",

I'll try to find time to clone, fix & pull request but I'm busy elsewhere so might not be soon.

@JurajNyiri
Copy link
Owner

Fixed in https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/releases/tag/5.4.24

@JurajNyiri JurajNyiri added the Fixed Bug has been fixed. label Jul 4, 2024
marcosngomezi pushed a commit to marcosngomezi/HomeAssistant-Tapo-Control that referenced this issue Jul 20, 2024
@JurajNyiri @marcosngomezi
Fix JurajNyiri#571: Incorrect device_class for D230 doorbell battery …
ce1e53e 
…sensor
JurajNyiri added a commit that referenced this issue Jul 20, 2024
@JurajNyiri @marcosngomezi
@AntwaneB @ldotlopez @Virenbar @natekspencer
Pull 559 preparation (#634)
4255ad1 
* changes

* tapo-siren-fix

* getMost-list-breaking-change

* siren-and-select

* comments

* fixes-and-comments

* numbers

* siren

* unneded-mapings

* cleanup

* testing-fixes

* cleanup

* Fix: PR does not work with C200 1.0 1.3.6

* fix-siren

* Update README.md to add instructions in case the cloud password does not work.

* Update README.md

* Update README.md

* Update README.md

* Implement color mode

Reference:
https://developers.home-assistant.io/docs/core/entity/light#color-modes

> New integrations must implement both color_mode and supported_color_modes.
> If an integration is upgraded to support color mode, both color_mode and
> supported_color_modes should be implemented.

This also fixes this warning at startup:

```
WARNING (MainThread) [homeassistant.components.light] None (<class 'custom_components.tapo_control.light.TapoWhitelight'>) does not set supported color modes, this will stop working in Home Assistant Core 2025.3, please create a bug report at https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/issues
```

* Create ru.json

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Fix #568: IP address is not a supported Tapo device

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

* Update issues.yml

Temporarily disable cloud password close bot

* Update issues.yml

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* changes

* tapo-siren-fix

* getMost-list-breaking-change

* siren-and-select

* comments

* fixes-and-comments

* numbers

* siren

* unneded-mapings

* cleanup

* testing-fixes

* cleanup

* fix-siren

* Handle cleanup of config entry

* Fix: PR does not work with C200 1.0 1.3.6

* alarm-status-false-default

* Fix #616: Warning for async_forward_entry_setup

* Fix #612, #615, #530, #525

* Fix: Blocking call when copying file from cold to hot storage

* Add: Binary sensor with details about media sync setup

* Fix #572: ffmpeg for sound detection doesn't terminate on Home Assistant restart

* Fix #561: Unexpected error fetching Tapo resource status data

* Fix #571: Incorrect device_class for D230 doorbell battery sensor

* Fix: Descalate "Recording is currently in progress." warning to info on media sync

* Add: HDR switch

* Add: Experimental optimization for battery cameras

* Fix: Update interval is now based on whether the device has a battery or not

* Update: Automatically determine whether the device is currently running on battery or not and adjust update interval

* Fix: Camera entities ignoring update threshold

* Update README.md

* Update README.md

* Create add_camera_with_new_firmware.md

* Update README.md

* Update add_camera_with_new_firmware.md

* Update add_camera_with_new_firmware.md

* Fix #629, #621: Setup for switch entities fails for some cameras

* Add #457: Battery optimization for solar cameras

* Update: Migrate update interval to config entry storage

* Add: Configurable update interval

* Update: Bump version

* Update: Guides for new firmwares workaround

* Update: Readme instructions about stopping use of tapo app not required

* Update: Readme formatting

* Update README.md

* Update add_camera_with_new_firmware.md

* Update README.md

* Fix: Removal of disabled device results in error and warning, time sync debug log

* Fix #450: Config entry name resets on reconfiguration

* Update: Bump version

* Fix: stopManualAlarm instead of start on siren off

* Fix: Mute error on siren on/off

* Update: Revert result_has_error changes

* Update: Ensure compatibility with #632

---------

Co-authored-by: marcosngomezi <[email protected]>
Co-authored-by: Antoine Buchser <[email protected]>
Co-authored-by: L. López <[email protected]>
Co-authored-by: Virenbar <[email protected]>
Co-authored-by: Nathan Spencer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed Bug has been fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JurajNyiri @Spamfast