RDG::local_to_global_id should be an arrow::Array, not a arrow::ChunkedArray

[witchel]

See PR #55.

[arthurp]

Code changes have renamed the stuff involved, but this issue still exists:

katana/libtsuba/include/tsuba/RDG.h

Line 154 in e5cdbf5

const std::shared_ptr<arrow::ChunkedArray>& local_to_global_id() const {

[witchel]

Way to stay on top of things! I spent some effort trying to convert local_to_global_id to an Array, but RDG mostly deals with ChunkedArrays, which it must to read/write Arrow tables. At that point, I figured too much consistency was the hobgoblin of little minds. But I thought maybe the root problem was my laziness, so I kept the comment and the issue open.

[arthurp]

I think some cases we convert ChunkedArray to Array in PropertyGraph by failing if there is more than one chunk. (We definitely used to.) I don't know as this will scale all that well, because chunk arrays can be longer than unchunked arrays. But depending on requirements we might be able to change PropertyGraph to use an Array while allowing RDG to still use a ChunkedArray.

PS: I try to procrastinate productively, so I will scan old issues and update them. ;-)

[witchel]

Well, Unchunk in ArrowInterchange.h in libsupport will correctly convert from a ChunkedArray to an Array, but as you say, there are length restrictions on Arrays that could be problematic.

I think I read that Euler would check ever-increasing number ranges for primes when he had free time. Maybe that was Newton. Anyway, thank god for Netflix.