-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Lazy Camera Loading for Efficient Compression of Large Files with Numerous Images and Corresponding Cameras (#8) #9
base: master
Are you sure you want to change the base?
Conversation
… with Numerous Images and Corresponding Cameras (KeKsBoTer#8) - Implemented LazyCameraLoader class in camera_utils.py to enable on-demand loading and unloading of cameras. - Refactored calc_importance function to use LazyCameraLoader for efficient memory management. - Modified finetune function to leverage LazyCameraLoader and ensure memory is freed after processing each camera. - Improved memory usage and performance during sensitivity calculation and finetuning processes. - This solution is particularly beneficial for handling large files and datasets, though it may not be as efficient for smaller datasets. This commit addresses issue KeKsBoTer#8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tried but sttill out of memory. gaussian splatting model used about 4000x 4k photo.my device has 660g ram and 3x tesla l20 48Gb vram. date put into cpu memory |
Each image was 4MB and you had 4000 of them? How many splats were in your scene when it crashed? |
4 |
I tried by a 1.1TB RAM device.still out of memory |
I need to dig up the code again and take a look. I know we had this issue fixed. Is this a time sensitive issue for you? |
It`s all the time,and anyway to fix it?
…________________________________
发件人: Andrew Ryan Carpenter ***@***.***>
发送时间: 2024年11月12日 9:15
收件人: KeKsBoTer/c3dgs ***@***.***>
抄送: 白致远 ***@***.***>; Comment ***@***.***>
主题: Re: [KeKsBoTer/c3dgs] Optimize Lazy Camera Loading for Efficient Compression of Large Files with Numerous Images and Corresponding Cameras (#8) (PR #9)
I need to dig up the code again and take a look. I know we had this issue fixed. Is this a time sensitive issue for you?
―
Reply to this email directly, view it on GitHub<#9 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APFN7UP7KXUIPMUXS7G3P7D2AFJE3AVCNFSM6AAAAABKDWVYWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZGM4TAMRRHA>.
You are receiving this because you commented.
|
so anyway to fix it? |
Use something like this:
|
This commit addresses issue #8.