Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decodeSequentially does not pass SerialDescriptor #2916

Open
hfhbd opened this issue Feb 3, 2025 · 1 comment
Open

decodeSequentially does not pass SerialDescriptor #2916

hfhbd opened this issue Feb 3, 2025 · 1 comment
Labels

Comments

@hfhbd
Copy link
Contributor

hfhbd commented Feb 3, 2025

What is your use-case and why do you need this feature?

decodeSequentially is the only function of CompositeDecoder that does not have the SerialDescriptor as parameter. I need to dynamically check if the data is sequentially and I need the SerialNames (getElementName) of the SerialDescriptor.

As a workaround I check if the data is sequentially in beginStructure.

Describe the solution you'd like
Add SerialDescriptor as parameter to decodeSequentially. It is a breaking change but the api is marked as experimental so it should be fine.

@hfhbd hfhbd added the feature label Feb 3, 2025
@sandwwraith
Copy link
Member

Indeed, adding it can be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants