Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more graphs for phate.fit #141

Open
dsm-72 opened this issue Dec 9, 2023 · 0 comments
Open

Support more graphs for phate.fit #141

dsm-72 opened this issue Dec 9, 2023 · 0 comments

Comments

@dsm-72
Copy link

dsm-72 commented Dec 9, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

See this:

if isinstance(X, graphtools.graphs.LandmarkGraph) or (

The result is that if gt.Graph(...) yields something like kNNGraph it will get converted to another graph object e.g. TraditionalGraph.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Let me pass in a graph for fit / fit_transform and have that graph be stored under phate.graph

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
keeping both objects around.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant