Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issue in Overnight-usdp, Ramses-v2 & Curve-xCrypto-Ng #730

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Fix some issue in Overnight-usdp, Ramses-v2 & Curve-xCrypto-Ng #730

merged 6 commits into from
Feb 18, 2025

Conversation

sunspirit99
Copy link
Contributor

Why did we need it?

Related Issue

Release Note

How Has This Been Tested?

Screenshots (if appropriate):

sunspirit99 and others added 4 commits February 17, 2025 10:04
@sunspirit99
tmp
bf319ce
@minhnhathoang @sunspirit99
feat: integrate savings-usds/sky-psm (#723)
60559cf 
* add testutil.TestCalcAmountIn

* simplify block timestamp

* use MulDivOverflow

* use common pool type
@tien7668 @sunspirit99
fix remaining taker amount (#729)
3e9d0e2
@sunspirit99
tmp
3083241
@kyber-ci-bot
Copy link

Test coverage changes:
Package Before After Diff
github.com/KyberNetwork/kyberswap-dex-lib/pkg/entity 26.30% 26.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/algebra/integral 59.90% 59.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/algebra/v1 19.20% 19.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/ambient 17.90% 17.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v1 42.80% 42.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v2/composable-stable 48.70% 48.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v2/math 49.00% 49.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v2/stable 33.80% 33.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v2/weighted 44.90% 44.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v3/math 34.30% 34.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v3/stable 26.30% 26.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v3/weighted 26.50% 26.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/bancor-v21 31.70% 31.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/bancor-v3 51.20% 51.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/bebop 26.40% 26.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/bedrock/unieth 16.90% 16.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/beets-ss 25.50% 25.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/clipper 50.00% 50.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/plain 59.30% 59.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/stable-meta-ng 42.00% 42.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/stable-ng 37.70% 37.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/tricrypto-ng 62.20% 62.00% ❌
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/twocrypto-ng 61.00% 61.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dai-usds 21.90% 21.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/deltaswap-v1 46.20% 46.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dexalot 45.10% 45.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/classical 59.10% 59.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/dpp 38.50% 38.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/dsp 41.00% 41.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/dvm 49.50% 49.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/libv1 73.30% 73.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/libv2 37.60% 37.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/ethena/susde 27.10% 27.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/ether-vista 2.30% 2.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/etherfi/ebtc 36.60% 36.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/etherfi/eeth 16.00% 16.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/etherfi/vampire 27.10% 27.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/etherfi/weeth 12.30% 12.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/fluid/dex-t1 71.10% 71.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/fluid/vault-t1 17.70% 17.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/frax/sfrxeth 18.00% 18.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/frax/sfrxeth-convertor 37.50% 37.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/generic-simple-rate 32.90% 32.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/gyroscope/2clp 42.30% 42.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/gyroscope/3clp 43.90% 43.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/gyroscope/eclp 58.80% 58.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/gyroscope/math 14.30% 14.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/hashflow-v3 74.30% 74.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/integral 35.70% 35.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/kelp/rseth 11.80% 11.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/kyber-pmm 75.60% 75.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/lo1inch 77.40% 77.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/lo1inch/helper 54.20% 54.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/maker/savingsdai 31.30% 31.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/maker/sky-psm 46.20% 46.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/mantle/meth 28.10% 28.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/mkr-sky 29.70% 29.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/mx-trading 72.00% 72.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/native-v1 69.20% 69.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/nomiswap/nomiswapstable 83.10% 83.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/ondo-usdy 23.90% 23.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/overnight-usdp 29.10% 29.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/puffer/pufeth 22.80% 22.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/renzo/ezeth 9.40% 9.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/ringswap 10.70% 10.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/rocketpool/reth 26.10% 26.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/solidly-v2 32.10% 32.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/staderethx 28.00% 28.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/swaap-v2 56.40% 56.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/swell/rsweth 6.20% 6.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/swell/sweth 6.20% 6.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/syncswapv2/aqua 24.00% 24.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/syncswapv2/classic 41.10% 41.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/syncswapv2/stable 48.60% 48.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/uniswap-v1 13.90% 13.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/uniswap-v2 8.20% 8.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/usd0pp 27.30% 27.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velocore-v2/cpmm 54.50% 54.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velocore-v2/math 16.80% 16.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velocore-v2/math/sd59x18 51.90% 51.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velocore-v2/wombat-stable 30.40% 30.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velodrome-v1 35.10% 35.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velodrome-v2 40.20% 40.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/virtual-fun 38.90% 38.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/woofi-v2 55.20% 55.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/woofi-v21 57.50% 57.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/camelot 38.70% 38.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/aave 70.70% 70.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/base 43.50% 43.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/compound 75.40% 75.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/meta 86.80% 86.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/plain-oracle 38.50% 38.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/tricrypto 70.30% 70.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/two 29.20% 29.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/dmm 33.30% 33.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/equalizer 28.80% 28.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/fraxswap 23.90% 23.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/fulcrom 31.60% 31.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/fxdx 20.90% 20.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/gmx 27.20% 27.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/gmx-glp 26.30% 26.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/iziswap 25.10% 25.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/kokonut-crypto 55.50% 55.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/lido 22.80% 22.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/lido-steth 33.30% 33.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/limitorder 53.30% 53.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/liquiditybookv20 37.90% 37.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/liquiditybookv21 50.60% 50.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/madmex 25.10% 25.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/makerpsm 37.30% 37.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/mantisswap 53.10% 53.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/maverickv1 66.70% 66.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/metavault 28.40% 28.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/nuriv2 22.60% 22.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/pancakev3 26.10% 26.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/platypus 26.00% 26.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/pol-matic 18.90% 18.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/quickperps 23.90% 23.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/ramsesv2 21.50% 22.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/saddle 64.00% 64.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/slipstream 24.00% 24.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/smardex 46.20% 46.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/solidly-v3 28.60% 28.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/swapbased-perp 31.40% 31.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/syncswap/syncswapclassic 68.30% 68.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/syncswap/syncswapstable 82.50% 82.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/synthetix 38.00% 38.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/uniswap 17.00% 17.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/uniswapv3 27.20% 27.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/usdfi 44.10% 44.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/velocimeter 46.60% 46.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/vooi 36.90% 36.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/wombat/wombatlsd 55.30% 55.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/wombat/wombatmain 56.50% 56.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/util 4.50% 4.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/util/abi 75.00% 75.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/util/bignumber 14.80% 14.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/util/graphql 56.20% 56.20% ✔️

NgoKimPhu
NgoKimPhu reviewed Feb 18, 2025
View reviewed changes
pkg/liquidity-source/curve/shared/pools_list_updater.go
@@ -26,7 +26,7 @@ type (
}

Config struct {
DexID string `mapstructure:"dex_id" json:"dex_id,omitempty"`
DexID string `mapstructure:"dexID" json:"dexID,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the same casing style for the other fields as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need to update config in pool service too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's better when do it on the next PR :)

@sunspirit99 sunspirit99 merged commit 57b3838 into main Feb 18, 2025
5 checks passed
@sunspirit99 sunspirit99 deleted the update-overnight-usdp branch February 18, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NgoKimPhu NgoKimPhu NgoKimPhu approved these changes

@piavgh piavgh Awaiting requested review from piavgh piavgh is a code owner

@it4rb it4rb Awaiting requested review from it4rb it4rb is a code owner

@lehainam-dev lehainam-dev Awaiting requested review from lehainam-dev lehainam-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunspirit99 @kyber-ci-bot @NgoKimPhu @minhnhathoang @tien7668