Contributing to the official modularscale.com js plugin

[scottkellum]

Nice to see some work on this! Found through automated tweets after registering with NPM.

Are you doing anything differently than the modular scale calculator that powers modularscale.com? Is there anything we are doing wrong or could be doing better? If you’re interested and have ideas on ways it can be better it’d be great to have your help there.

[KyleAMathews]

Hi :-) thanks for your great work on modularscale.com! Discovering these ideas has made my typography way way better.

The reason I wrote a new one is:

1. it didn't look like your module was on NPM which I need
2. I wanted the musical scales to be included within the module
3. your calculator looks like it always generates an array of values which is useful for modularscale.com but not generally elsewhere.
4. since I write all my code in commonjs modules, it'd be painful to fit a bower package into my workflow.

Definitely be interested in merging the two projects as long as the code meets both our needs and is published on NPM.

[scottkellum]

Thanks, I’ll create cases for these.
#3 is incorrect, it should output a single value unless I merged a change I shouldn’t have.

Definitely interested in #4 and getting the package out to more people. I don’t usually write a lot of JS so am more familiar with Compass and Bower package management.

I’m going to add you as a contributor. Feel free to jump in if you’d like, would love to have some help. No pressure if you plan on carrying on, more power to you.

[KyleAMathews]

@scottkellum released this tonight — http://kyleamathews.github.io/react-typography/

[KyleAMathews]

How would you propose we collaborate (if at all)? Right now the two projects are different enough code wise that one or the other would have to change significantly...

[scottkellum]

Hey, React typography looks great!

I just took care of all the above issues

Function works pretty much the same way, defaults to the golden section and ms(1) outputs 1.618033988749895. Adding a ratio is a bit different because it goes ms(value, bases, ratios) instead of ms(value, bases).