-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
At least ratio for major third wrong #3
Comments
Want to PR a fix?
…--
Kyle Mathews
Blog: http://bricolage.io
Twitter: http://twitter.com/kylemathews
On Thu, Aug 29, 2019 at 7:38 AM, d4h0 < ***@***.*** > wrote:
Hi,
It seems at least the major third ratio is wrong:
"major third": 4/3
In the source file (
https://github.com/KyleAMathews/modularscale/blob/2fe5aa1c3915e41bc1c3a4099f66d6d950221a28/src/index.coffee#L7
) the major third ratio is 4/3, but on modularscale. com (
https://www.modularscale.com/ ) it's 4/5 (or 5/4 on Wikipedia (
https://en.wikipedia.org/wiki/Major_third ) ).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (
#3?email_source=notifications&email_token=AAARLB7PF3V6YIGLNMI5JFTQG7NNNA5CNFSM4ISDDHH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIHASOQ
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AAARLB3QUJG5JLLYLNF2DFLQG7NNNANCNFSM4ISDDHHQ
).
|
Alright, I'll check the other rations and create a pull request with the
fix or fixes.
I try to do it this evening or in the next few days.
Am Do., 29. Aug. 2019 um 22:12 Uhr schrieb Kyle Mathews <
[email protected]>:
… Want to PR a fix?
--
Kyle Mathews
Blog: http://bricolage.io
Twitter: http://twitter.com/kylemathews
On Thu, Aug 29, 2019 at 7:38 AM, d4h0 < ***@***.*** > wrote:
>
>
>
> Hi,
>
>
>
> It seems at least the major third ratio is wrong:
>
> "major third": 4/3
>
> In the source file (
>
https://github.com/KyleAMathews/modularscale/blob/2fe5aa1c3915e41bc1c3a4099f66d6d950221a28/src/index.coffee#L7
> ) the major third ratio is 4/3, but on modularscale. com (
> https://www.modularscale.com/ ) it's 4/5 (or 5/4 on Wikipedia (
> https://en.wikipedia.org/wiki/Major_third ) ).
>
>
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub (
>
#3?email_source=notifications&email_token=AAARLB7PF3V6YIGLNMI5JFTQG7NNNA5CNFSM4ISDDHH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIHASOQ
> ) , or mute the thread (
>
https://github.com/notifications/unsubscribe-auth/AAARLB3QUJG5JLLYLNF2DFLQG7NNNANCNFSM4ISDDHHQ
> ).
>
>
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AABM37PBOC6VJQZ5L6LI4VLQHAURXA5CNFSM4ISDDHH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5PVUXA#issuecomment-526342748>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABM37MJXZK662X6CMMI4KTQHAURXANCNFSM4ISDDHHQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
It seems at least the major third ratio is wrong:
In the source file the major third ratio is 4/3, but on modularscale.com it's 4/5 (or 5/4 on Wikipedia).
The text was updated successfully, but these errors were encountered: