From bc443152d0eaf53938ccc9d902374f7df085db8f Mon Sep 17 00:00:00 2001 From: tomeichlersmith Date: Thu, 6 Jan 2022 09:46:23 -0600 Subject: [PATCH] patch PR template to match actual testing procedure --- .github/PULL_REQUEST_TEMPLATE.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f66a16e..a85aec5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -20,14 +20,15 @@ ldmx-container-pull local temp-tag cd ldmx-sw mkdir build cd build -ldmx cmake -DBUILD_TESTS=ON .. +ldmx cmake .. ldmx make install ``` - [ ] I was able to test run a small simulation and reconstruction inside this container ``` # outline of test instructions -cd $LDMX_BASE -ldmx run_test +cd $LDMX_BASE/ldmx-sw/build +ldmx ctest +cd .. for c in `ls ldmx-sw/*/test/*.py`; ldmx fire $c; done ``` - [ ] I was able to successfully use the new packages. Explain what you did to test them below: