Follow the electron to HCAL and potentially dont use its hits for max PE #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvami
changed the title
tvami
changed the title
* Add ACTS tracking in all CIs * Dont switch the tracking in ecal on yet * Move to `ldmx-reduced-v2` in CI * Move to p.logger for logging --------- Co-authored-by: Tom Eichlersmith <[email protected]>
tvami
force-pushed
the
iss1519-follow-e-to-hcal
branch
from
9a72c98 to
dd1f52a
Compare
tvami
changed the title
|
I switched OFF the new development, i.e. right now this PR adds the HCAL veto as it used to be for the CIs, together with a dedicated DQM. I'd like to have this merged before the next patch release, so that the next PR when I switch this ON can show the changes in those DQM histograms. |
|
Oh I also renamed to |
tomeichlersmith
approved these changes
Jan 24, 2025
danyi211
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1519
Check List