Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Mismatch in TCs and hexa-modules mutual position #22

Open
mchiusi opened this issue Feb 28, 2023 · 2 comments
Open

[Bug] Mismatch in TCs and hexa-modules mutual position #22

mchiusi opened this issue Feb 28, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mchiusi
Copy link
Collaborator

mchiusi commented Feb 28, 2023

Bug description
The mutual position of TCs and hexa-modules is not correct.
Some TCs come out of their hexagonal module or cross the border. See some examples attached.

Code to correct
The geometry of TCs and hex-modules in the electromagnetic section of the calorimeter is computed here.

The most correlated variables to this issue are diamond_x, diamond_y and hex_x, hex_y.

PR #10

Screenshot 2023-02-28 at 09 59 15
Screenshot 2023-02-28 at 10 01 12

@mchiusi mchiusi added the bug Something isn't working label Feb 28, 2023
@bfonta
Copy link
Collaborator

bfonta commented Feb 28, 2023

@mchiusi Thanks for reporting (I see that you've updated your GUI's aesthetics!).
Could you please display a single full wafer with all its trigger cells overlayed? I want to understand if this is is just a shift (which I observed in the past on my side), or if it is more convoluted.

@mchiusi
Copy link
Collaborator Author

mchiusi commented Feb 28, 2023

Yes! More formal now.
About the display that you asked me, something like this can be useful? These are the TCs of module (u,v) = (4,-2), layer 7.
If you prefer I can display a particular hexagonal module of a particular layer. Let me know.

Screenshot 2023-02-28 at 12 04 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants