Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null Exception on gui open #760

Open
3 tasks done
00Hrtz opened this issue Jan 19, 2025 · 8 comments · May be fixed by #762
Open
3 tasks done

Null Exception on gui open #760

00Hrtz opened this issue Jan 19, 2025 · 8 comments · May be fixed by #762
Labels
bug priority: high status: accepted Feature request accepted / bug report confirmed

Comments

@00Hrtz
Copy link

00Hrtz commented Jan 19, 2025 •
edited
Loading

Description of Bug

Got this warn when i opened the quest menu https://paste.helpch.at/itowebofoy.rb

Steps to Reproduce

running paper 1.21.1

not sure it happened after i opened the quest gui or just before i opened a quest category.

Although i have attempted to replicate it straight after and it's only happened that one time.

Environment

  • Minecraft version: 1.21.1
  • Server software: Paper version 1.21.1-132-ver/1.21.1@b48403b (2024-11-21T10:14:27Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
  • Quests version: 3.15.2

Agreements

  • I am running the latest version of Quests
  • I am certain this issue is unique and a similar issue is not currently open
  • I am using a version of Minecraft which is supported by Quests

Other

No response
@00Hrtz 00Hrtz added bug status: needs investigating Bug report / feature request needs investigating and triage labels Jan 19, 2025
@00Hrtz
Copy link
Author

00Hrtz commented Jan 19, 2025

just happened again, seems to be happening when you open the quests gui

@JobsonMarinho JobsonMarinho linked a pull request Feb 1, 2025 that will close this issue
Open
@JobsonMarinho
Copy link

Hi! I have submitted a pull request that addresses the ConcurrentModificationException in the checkExpiredQuests method. In this fix, I am now collecting the quests to expire in a temporary list and then removing them after the iteration is complete. This approach prevents modification of the collection during iteration.

You can check the PR here: PR Link.

Krakenied added a commit to Krakenied/Quests that referenced this issue Feb 1, 2025
@Krakenied
Update CustomFishing dependency
1866150 
Add isPrimaryThread method for LMBishop#760 debugging
@Krakenied
Copy link
Collaborator

Do you use Quests placeholders in the opened GUI?

@00Hrtz
Copy link
Author

00Hrtz commented Feb 5, 2025

Do you use Quests placeholders in the opened GUI?

i have quest placeholders in everything, quests and categories

@Krakenied
Copy link
Collaborator

Krakenied commented Feb 5, 2025 •
edited
Loading

These from PAPI? (using %)

@00Hrtz
Copy link
Author

00Hrtz commented Feb 5, 2025

These from PAPI? (using %)

yes official papi quest placeholders, the issue isn't happening anymore, it was just a one off occurrence to date.

@00Hrtz
Copy link
Author

00Hrtz commented Feb 5, 2025

if it happens in the future i'll report it again

@Krakenied
Copy link
Collaborator

Well, it will, it's just really difficult to reproduce since it's a concurrency issue

@Krakenied Krakenied added status: accepted Feature request accepted / bug report confirmed priority: high and removed status: needs investigating Bug report / feature request needs investigating and triage labels Feb 5, 2025
Krakenied added a commit to Krakenied/Quests that referenced this issue Feb 11, 2025
@Krakenied
Add a switch for LMBishop#760 debugging
4bb3a15 
Closes LMBishop#763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority: high status: accepted Feature request accepted / bug report confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ConcurrentModificationException in checkExpiredQuests method JobsonMarinho/Quests
3 participants
@Krakenied @JobsonMarinho @00Hrtz