Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in number field search return #6329

Open
jenpaulhus opened this issue Feb 22, 2025 · 3 comments
Open

Error in number field search return #6329

jenpaulhus opened this issue Feb 22, 2025 · 3 comments
Labels
number fields Number fields
Milestone

Comments

@jenpaulhus
Copy link
Contributor

From the bugreport:

I was using the LMFDB to search for totally real biquadratic fields (i.e. "signature = [4,0]" and "field_is=multi_quad" ). However, this search also seems to erroneously return degree 2 fields, which I assume shouldn't be in the search results?

Here's the search:
https://www.lmfdb.org/NumberField/?signature=%5B4%2C0%5D&field_is=multi_quad

@jenpaulhus jenpaulhus added the number fields Number fields label Feb 22, 2025
@AndrewVSutherland
Copy link
Member

It does the right thing if you also specify the degree, but this certainly looks like a bug.

@roed314
Copy link
Contributor

roed314 commented Feb 22, 2025

We need to account for signature as a constraint on degree in addition to info["degree"] on line 914 of number_field.py.

@roed314
Copy link
Contributor

roed314 commented Feb 22, 2025

Note that we use integer_options there rather than directly accessing query["degree"] since we could have a complicated degree input like 2,3,6-8,12-20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
number fields Number fields
Projects
None yet
Development

No branches or pull requests

3 participants