Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Keep signal-file metadata in separate dataframe #8

Open
WilliamCappelletti opened this issue Jul 6, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@WilliamCappelletti
Copy link
Member

Is your feature request related to a problem? Please describe.

Much information is unnecessarily duplicated in the segments dataframe (e.g. date and sampling rate). We could move all that to a separate dataframe indexed by file name.
In there we could also include

  • Available channels
  • Path to original file

Describe the solution you'd like

A separate file would carry all that information.

Problems

We would have to provide another dataframe to EEGDataset, unless the segments df point to the metadata instead of the actual file (this requires reading two files at each call).

@WilliamCappelletti WilliamCappelletti added the enhancement New feature or request label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant