Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in step 1 of Getting Started page #584

Closed
nulele opened this issue Jul 5, 2024 · 2 comments
Closed

Discrepancy in step 1 of Getting Started page #584

nulele opened this issue Jul 5, 2024 · 2 comments
Assignees

Comments

@nulele
Copy link

nulele commented Jul 5, 2024

Hello,

I was comparing the UserCrudController generated by php artisan backpack:crud user command with the step 1 of "Getting Started" page when I first open the admin dashboard and I found a discrepancy.

Well, the documentation says:

  1. When Listing, let's remove the "password" column - no point in showing the hash. To do that, go to UserCrudController::setupListOperation() and remove the line saying CRUD::column('password'); - easy-peasy, right?

but the method of the controller is:

    /**
     * Define what happens when the List operation is loaded.
     * 
     * @see  https://backpackforlaravel.com/docs/crud-operation-list-entries
     * @return void
     */
    protected function setupListOperation()
    {
        CRUD::setFromDb(); // set columns from db columns.

        /**
         * Columns can be defined using the fluent syntax:
         * - CRUD::column('price')->type('number');
         */
    }

I have the pro version and the packages versions are:

  • backpack/pro: 2.2.4
  • backpack/generators: 4.0.5

Maybe do I need to set some configuration parameter?

Thanks

@jcastroa87
Copy link
Member

Hello @nulele

Thanks for this, we will check about this docs and updated as needed.

Cheers.

@jcastroa87
Copy link
Member

Hello @nulele

Thanks for this found, we are working to fix it now in this PR

I will close this issue, but please feel free to re-open or create a new one if needed.

Cheers.

@github-project-automation github-project-automation bot moved this from Needs Testing, Review or Docs to Done in This week Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants