You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small bug, caused by checking if the blockstate parameters are exactly the same (which they won't be if they're different styles)
Adding the below line of code after lines 97 and 116 of /content/buffer/headstock/CopycatHeadstockBlock.java would fix it. if (toState.getBlock() instanceof this) {toState.setValue(STYLE, state.getValue(STYLE));}
As you could probably tell, it would make the methods isIgnoredConnectivitySide and canConnectTexturesToward pretend that the secondary headstock blockstate had the same STYLE value as the origin headstock blockstate.
But before forcing the STYLE value to be equal (and thus ostensibly ignored), it would ensure that it is a Copycat Headstock block, otherwise I doubt anything good would happen.
I don't care about credit, I just wanted to help out, and for two lines of code it's not really worth a pull request. So if you think it would work, you have my word to just paste it in.
Cheers!
Reproduction Steps
Place two adjacent Copycat Headstock blocks of the same style (both buffers or both empty, etc.), facing the same way and the same height
Place a block that has connecting textures into both
The texture connects
Now place two adjacent Copycat Headstock blocks of different styles (one a buffer, one empty, one a coupler, etc., facing the same way and the same height
The texture does not connect
...
Expected Result
The texture should connect
Screenshots and Videos
Crash Report or Log
N/A
Operating System
Linux Mint 21.3 Cinnamon
Mod Version
1.6.4
Create Mod Version
0.5.1f
Minecraft Version
1.20.1
ModLoader and Version
Forge 47.3.1
Other Mods
N/A
Additional Context
No response
The text was updated successfully, but these errors were encountered:
Describe the Bug
Small bug, caused by checking if the blockstate parameters are exactly the same (which they won't be if they're different styles)
Adding the below line of code after lines 97 and 116 of /content/buffer/headstock/CopycatHeadstockBlock.java would fix it.
if (toState.getBlock() instanceof this) {toState.setValue(STYLE, state.getValue(STYLE));}
As you could probably tell, it would make the methods
isIgnoredConnectivitySide
andcanConnectTexturesToward
pretend that the secondary headstock blockstate had the sameSTYLE
value as the origin headstock blockstate.But before forcing the
STYLE
value to be equal (and thus ostensibly ignored), it would ensure that it is a Copycat Headstock block, otherwise I doubt anything good would happen.I don't care about credit, I just wanted to help out, and for two lines of code it's not really worth a pull request. So if you think it would work, you have my word to just paste it in.
Cheers!
Reproduction Steps
...
Expected Result
The texture should connect
Screenshots and Videos
Crash Report or Log
N/A
Operating System
Linux Mint 21.3 Cinnamon
Mod Version
1.6.4
Create Mod Version
0.5.1f
Minecraft Version
1.20.1
ModLoader and Version
Forge 47.3.1
Other Mods
N/A
Additional Context
No response
The text was updated successfully, but these errors were encountered: