Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copycat Headstocks of different styles do not connect textures #505

Closed
SeveringHams opened this issue Jul 18, 2024 · 0 comments
Closed

Copycat Headstocks of different styles do not connect textures #505

SeveringHams opened this issue Jul 18, 2024 · 0 comments
Labels
type: bug Something isn't working version: 1.20 Version: Minecraft 1.20.x

Comments

@SeveringHams
Copy link

SeveringHams commented Jul 18, 2024

Describe the Bug

Small bug, caused by checking if the blockstate parameters are exactly the same (which they won't be if they're different styles)

Adding the below line of code after lines 97 and 116 of /content/buffer/headstock/CopycatHeadstockBlock.java would fix it.
if (toState.getBlock() instanceof this) {toState.setValue(STYLE, state.getValue(STYLE));}

As you could probably tell, it would make the methods isIgnoredConnectivitySide and canConnectTexturesToward pretend that the secondary headstock blockstate had the same STYLE value as the origin headstock blockstate.

But before forcing the STYLE value to be equal (and thus ostensibly ignored), it would ensure that it is a Copycat Headstock block, otherwise I doubt anything good would happen.

I don't care about credit, I just wanted to help out, and for two lines of code it's not really worth a pull request. So if you think it would work, you have my word to just paste it in.

Cheers!

Reproduction Steps

  1. Place two adjacent Copycat Headstock blocks of the same style (both buffers or both empty, etc.), facing the same way and the same height
  2. Place a block that has connecting textures into both
  3. The texture connects
  4. Now place two adjacent Copycat Headstock blocks of different styles (one a buffer, one empty, one a coupler, etc., facing the same way and the same height
  5. The texture does not connect
    ...

Expected Result

The texture should connect

Screenshots and Videos

2024-07-18_12 37 23

Crash Report or Log

N/A

Operating System

Linux Mint 21.3 Cinnamon

Mod Version

1.6.4

Create Mod Version

0.5.1f

Minecraft Version

1.20.1

ModLoader and Version

Forge 47.3.1

Other Mods

N/A

Additional Context

No response

@SeveringHams SeveringHams added the type: bug Something isn't working label Jul 18, 2024
@github-actions github-actions bot added the version: 1.20 Version: Minecraft 1.20.x label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working version: 1.20 Version: Minecraft 1.20.x
Projects
None yet
Development

No branches or pull requests

1 participant