Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AsyncSmtpTransport.from_url to configure email? #5472

Open
Nutomic opened this issue Mar 3, 2025 · 1 comment
Open

Use AsyncSmtpTransport.from_url to configure email? #5472

Nutomic opened this issue Mar 3, 2025 · 1 comment
Milestone

Comments

@Nutomic
Copy link
Member

Nutomic commented Mar 3, 2025

This would be much simpler to handle, similar to the database connection which we also switched to url.

https://docs.rs/lettre/0.11.14/lettre/transport/smtp/struct.AsyncSmtpTransport.html#method.from_url

At the same time, it would make sense to enable the pool feature for connection pool, and store the email transport in OnceLock instead of building it from scratch every time.

@Nutomic Nutomic added enhancement New feature or request breaking change labels Mar 3, 2025
@Nutomic Nutomic added this to the 1.0.0 milestone Mar 3, 2025
@dessalines
Copy link
Member

dessalines commented Mar 3, 2025

I'd be fine with this, as long as we note the breaking change.

@dessalines dessalines reopened this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants