Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] - Is there a reason talent tooltips are hard-coded, instead of pulled from game API? #138

Open
mrchops1024 opened this issue Jul 15, 2024 · 1 comment

Comments

@mrchops1024
Copy link
Contributor

I've noticed through SoD phases, that a number of changes are made to talent tooltips, requiring updating the the static files in the repo.

@Lethay - Is there a reason you opted for hard-coding vs pulling from in-game API?

@Lethay
Copy link
Owner

Lethay commented Jul 15, 2024

Because in Vanilla and TBC Classic, the talent API doesn't allow the tooltips for ranks of talents that are not available to the player to be loaded, and especially not tooltips for other classes. This changed in WotLK classic (interestingly, mirroring when it changed in original WotLK). Note that I don't have hard coded data in the Wrath version of the addon. This might be "fixed" in SoD but I hadn't noticed that being the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants