Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash character in comments break comment #97

Open
BeastyBlacksmith opened this issue Jul 18, 2022 · 4 comments
Open

Hash character in comments break comment #97

BeastyBlacksmith opened this issue Jul 18, 2022 · 4 comments
Labels
🪲 bug Something isn't working

Comments

@BeastyBlacksmith
Copy link

<!-- # Commented Title -->

will show up on a LiaScript page and turn --> into an arrow.

@andre-dietrich andre-dietrich added the 🪲 bug Something isn't working label Jul 18, 2022
@andre-dietrich
Copy link
Member

If you remove the hash, it works ... since comments in LiaScript might have a meaning/purpose they are treated differently ... I will check this, since in this case it is an error ...

Thanks for reporting

@BeastyBlacksmith
Copy link
Author

Here is another case, that doesn't involve the hash character: <!-- TODO: fix this -->

@andre-dietrich
Copy link
Member

Thx for that one ... I think i will have to take a deeper look into the parsing rules ...

@nicolaibach
Copy link

I have another case: <!-- Lorem Ü --> also breaks comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants