Error in WaspFrame set Frame type method

[TheElk205]

I found a bug in your setFrame method, here.

waspmoteapi/libraries/Frame/WaspFrame.cpp

Line 781 in 5ded843

void WaspFrame::setFrameType(uint8_t type)

This will set the frame type wrong, as it 'ors' the new frame type with the old one.
It should be:

// protect two highest bits from beeing overwritten
uint8_t tmp = type & B00111111;
buffer[3] = tmp | (buffer[3] & B10000000);

As iv'e seen, there are still pull request open form 2014, should i still make one for this?

[Libelium]

Hi TheElk205,

It seems you're right. We will take a look into our library to correct it and we will upload the modifications in our next API release.

Thanks for your message.
Regards

[norhaneSupcom]

if i want to add new field in the header or new flags , how can i do this ? can i modify structure of header ??

[Libelium]

Hi norhaneSupcom,

You can modify createFrame() function to add new fields in the header but if you want to send data to Meshlium, it won't untestand the frames.

Regards

[norhaneSupcom]

ok, and i want to see a time on air in the back end for the example of : SX_02a_TX_LoRa , how can i did it ?

[Libelium]

Hi norhaneSupcom,

The SX1272 module is only able for P2P communication, for more information about the differences between LoRa and LoRaWan module please you check this link.

Also, if you have more doubts in the future about our technology please you post your problems at the Libelium forum.

https://www.libelium.com/forum/

Regards

[norhaneSupcom]

Hi, if i want to send a message of 400 byte, is it possible to integrate a message splitting function into several 250-byte packets ??? for exemple : i will send my message of 400 byte in two packets the first (250byte) and the second (150byte)

[Libelium]

As we said on the previous message please you should ask this kind of questions on the Libelium forum and our colleagues of the forum will help you very kindly to solve your doubts.

Regards