GPS load/save ephems turn on/off SD unconditionally

[jdavid]

waspmoteapi/libraries/GPS/WaspGPS.cpp

Line 2616 in 5ded843

SD.ON();

I think it should check REG_SD. I have changed the code so it reads like this:

bool _SD_ON = (WaspRegister & REG_SD);
if (! _SD_ON)
{
    SD.ON();
}

The current code has a couple of issues:

• If SD was OFF before, when leaving loadEphems it will be ON, wasting power.
• If SD was ON, turning it ON again fails with flag = ROOT_FAILED, as a consequence loadEphems fails.

[Libelium]

Hi,

It seems you are right about the issues. You should also add these lines of code into saveEphems() function.

Regards

[jdavid]

This bug is still present in v029

[Libelium]

Thanks for the reminder. Please don't hesitate to open new issues if you find new bugs at our API.

Regards

[jdavid]

This is partially fixed in v030, saveEphems() is still not fixed.