New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to wait after Wire.requestFrom() and it should not be followed by Wire.endTransmission(). #28

Open

Koepel opened this issue May 10, 2018 · 1 comment

Koepel commented May 10, 2018 •

edited

Loading

In the files:

waspmoteapi/libraries/SensorGas_PRO/MCP3421.cpp
waspmoteapi/libraries/UltrasoundSensor/UltrasoundSensor.cpp
waspmoteapi/waspmote-api/WaspEEPROM.cpp
waspmoteapi/waspmote-api/WaspRTC.cpp

there is waiting with timeout and sometimes a Wire.endTransmission() after a Wire.requestFrom(). All of that is not needed.

I assume that the changed Wire library still works just like the official Arduino Wire library.

Explanation: Common-mistakes, number 1 and 2.

Owner

Libelium commented May 14, 2018

Hi Koepel,

Thanks for your contribution. We will take a look into the API to correct it.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment