Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a project link without a sort order hangs the application #254

Open
redrun45 opened this issue Feb 6, 2025 · 0 comments
Open

Adding a project link without a sort order hangs the application #254

redrun45 opened this issue Feb 6, 2025 · 0 comments
Labels
area:workflow Volunteer-facing app - Section Compiler, Validator, et al. priority:medium

Comments

@redrun45
Copy link
Collaborator

redrun45 commented Feb 6, 2025

When adding custom links to a project (application/controllers/private/Administer_projects.php -> update_add_project_url()), if order is omitted, the server returns error 500. The client-side JS, expecting an AJAX response that never comes, displays a loading-spinner indefinitely.

While better error handling would be nice, the most direct fix would likely be to add a default value to project_urls.order. Since it's used for a relative sort, the value does not need to be unique, even among "sibling" links. Defaulting to 1 might be all we need for this particular issue.

@redrun45 redrun45 added area:workflow Volunteer-facing app - Section Compiler, Validator, et al. priority:medium labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:workflow Volunteer-facing app - Section Compiler, Validator, et al. priority:medium
Projects
None yet
Development

No branches or pull requests

1 participant