Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use storage_options even when IS_IN_STUDIO #414

Closed
grez72 opened this issue Nov 13, 2024 · 0 comments · Fixed by #415
Closed

use storage_options even when IS_IN_STUDIO #414

grez72 opened this issue Nov 13, 2024 · 0 comments · Fixed by #415
Labels
enhancement New feature or request

Comments

@grez72
Copy link
Contributor

grez72 commented Nov 13, 2024

🚀 Feature

Can the streaming.client.S3Client be modified to use the passes storage_options when they are passed in, even when in a STUDIO? Currently I pass in storage_options and they are ignored and STUDIO credentials are used instead. I would like to be able to use my storage credentials, but there's currently no easy way to do that.

Motivation

It's confusing when passed storage_options aren't used, difficult to figure out why private objects cannot be accessed when the passed storage_options should provide sufficient permissions. I know you can connect a studio to an s3 bucket, but I shouldn't have to if I've passed the required storage_options.

Pitch

Modify the S3Client code from this:

if has_shared_credentials_file or not _IS_IN_STUDIO:

to this:

if has_shared_credentials_file or not _IS_IN_STUDIO or self._storage_options:

Alternatives

It seems like setting shared_credentials_file is one way, but even still, when I pass storage_options, I would expect them to be used.

Additional context

NA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant