Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample no longer accepts evals::Int #156

Closed
gdalle opened this issue Dec 1, 2024 · 4 comments · Fixed by #157
Closed

Sample no longer accepts evals::Int #156

gdalle opened this issue Dec 1, 2024 · 4 comments · Fixed by #157

Comments

@gdalle
Copy link

gdalle commented Dec 1, 2024

Hi @LilithHafner,
Just so you know, release 1.3.0 seems to have broken my DifferentiationInterface tests because I used to pass evals=0 to Sample and this does not fly anymore? No big deal of course, just wanted to know if it was on purpose or not.

@LilithHafner
Copy link
Owner

I'm seeing

MethodError: no method matching Chairmarks.Sample(::Int64, ::Float64, ::Float64, ::Float64, ::Float64, ::Float64, ::Float64, ::Float64, ::Float64)

In the CI logs for DifferentiationInterface which indicates that you are constructing Samples with all nine arguments enumerated. I can confirm that I broke that in 1.3.0. I'll fix it in 1.3.1. Thanks for reporting.

@LilithHafner
Copy link
Owner

(You can still use Sample(evals=0) in 1.3.0, just not Sample(0, NaN, NaN, NaN, NaN, NaN, NaN, NaN, NaN))

@LilithHafner
Copy link
Owner

I've attempted to fix this in 1.3.1 and triggered registration. Please let me know if you run into any other issues :)

@gdalle
Copy link
Author

gdalle commented Dec 2, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants