Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series.segment returning wrong object type #266

Closed
alexkjames opened this issue Sep 29, 2022 · 4 comments
Closed

Series.segment returning wrong object type #266

alexkjames opened this issue Sep 29, 2022 · 4 comments
Assignees

Comments

@alexkjames
Copy link
Contributor

Describe the bug
If the segment() method is used on a LipdSeries object and gaps are detected, the subsequent MultipleSeries object contains Series objects instead of LipdSeries objects.

To Reproduce
Create a LipdSeries object with gaps in the time axis and apply .segment().

Expected behavior
The MultipleSeries object produced by .segment() should contain the same type of object (and associated metadata) as the one it was applied to.

Notes
This might be a good place to apply the new log functionality, as changes in the time axis of the LipdSeries object will go unrecorded in the attached lipd_ts attribute.

@khider
Copy link
Member

khider commented Nov 1, 2022

Since we may change the architecture of LipdSeries, this may no longer be an issue. Wait until we learn more about how we want to handle data coming from a LiPD file

@CommonClimate
Copy link
Collaborator

@alexkjames did you end up resolving this?

@alexkjames
Copy link
Contributor Author

@CommonClimate No, still waiting to hear regarding the fate of LipdSeries objects (see deborah's comment above)

@CommonClimate
Copy link
Collaborator

revisit after #270 is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants