Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Added ping as status check #1811

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

chmaurer
Copy link

@chmaurer chmaurer commented Feb 5, 2025

chmaurer Medium chmaurer /master → Lissy93/dashy Commits: 1 | Files Changed: 3 | Additions: 87 Label Unchecked Tasks Powered by Pull Request Badge

Category:

One of: Feature

Overview

More or less completely new to nodejs, but still wanting to contribute; I have added some code sample found on S/O, edited it with AI, poured in some elbow grease and had a working docker image which allows to do pings additionally to http status checks. This is helpful i.e. for monitoring devices which are on the network, but not on layer 7.

Issue Number (if applicable) #00

New Vars (if applicable)
Yes, actually to create the Image object you need canvas. Added in some more dependencies, but unsure which are really needed, sorry. I'm more or less completely new to nodejs.

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@chmaurer chmaurer requested a review from Lissy93 as a code owner February 5, 2025 20:25
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit a2a9a88
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/67a5292e3bcbde0008f84b9c
😎 Deploy Preview https://deploy-preview-1811--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant