🐛 Fix a bug in RssFeed widget that crashes on small feeds. #1817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RssFeed would always default to
this.limit
for the size of the feed item array. Feeds that came in with fewer items than the limit would throw an exception, because the loop would then try to iterate over non-existent entries.Category: Bugfix
Overview
The RssFeed widget would always try to read
this.limit
items from the array. For feeds with fewer items, it would throw an exception. My change will populate the lesser between: (the actual qty of items, or the limit).Issue Number (if applicable)
N/A
New Vars (if applicable)
N/A
Screenshot (if applicable)
N/A
Code Quality Checklist (Please complete)