Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Translations #559

Open
BlobbyBob opened this issue Jan 19, 2025 · 1 comment
Open

Optimize Translations #559

BlobbyBob opened this issue Jan 19, 2025 · 1 comment
Labels
chore refactoring Refactor existing code to make it better

Comments

@BlobbyBob
Copy link
Collaborator

At the moment there are plenty of duplicate translations, often due to scoping of general terms. Examples:

src/assets/i18n/maps/de.json:5:  "mapMarkerForm.required": "Pflichtfeld",
src/assets/i18n/linePath/de.json:5:  "linePathForm.required": "Pflichtfeld",
src/assets/i18n/crag/de.json:10:  "cragForm.required": "Pflichtfeld",
src/assets/i18n/topoImage/de.json:14:  "topoImageForm.required": "Pflichtfeld",
src/assets/i18n/line/de.json:14:  "lineForm.required": "Pflichtfeld",
src/assets/i18n/line/de.json:24:  "lineForm.requiredValidationError": "Pflichtfeld",
src/assets/i18n/sector/de.json:10:  "sectorForm.required": "Pflichtfeld",
src/assets/i18n/de.json:60:  "region.regionForm.required": "Pflichtfeld",
src/assets/i18n/de.json:81:  "menuPages.menuPageForm.required": "Pflichtfeld",
src/assets/i18n/de.json:99:  "menuItems.menuItemForm.required": "Pflichtfeld",
src/assets/i18n/de.json:125:  "gallery.galleryForm.required": "Pflichtfeld",
src/assets/i18n/de.json:147:  "resetPassword.required": "Pflichtfeld",
src/assets/i18n/de.json:158:  "register.required": "Pflichtfeld",
src/assets/i18n/de.json:167:  "refreshLoginModal.required": "Pflichtfeld",
src/assets/i18n/de.json:178:  "login.required": "Pflichtfeld",
src/assets/i18n/de.json:186:  "instanceSettings.instanceSettingsForm.required": "Pflichtfeld",
src/assets/i18n/de.json:225:  "forgotPassword.required": "Pflichtfeld",
src/assets/i18n/de.json:231:  "changePassword.required": "Pflichtfeld",
src/assets/i18n/de.json:255:  "accountForm.required": "Pflichtfeld",
src/assets/i18n/de.json:271:  "posts.postForm.required": "Pflichtfeld",
src/assets/i18n/de.json:284:  "projectClimbedForm.required": "Pflichtfeld",
src/assets/i18n/de.json:297:  "ascentForm.required": "Pflichtfeld",
src/assets/i18n/area/de.json:10:  "areaForm.required": "Pflichtfeld",

Furthermore, some translations are overly specific and would benefit from transloco's parametrization. Examples:

  • *.maxlength120
  • resetPassword.minLength8
  • top25Ranking

These issues should be optimized to facilitate adding new languages.

@BlobbyBob BlobbyBob added enhancement Improves existing features refactoring Refactor existing code to make it better chore and removed enhancement Improves existing features labels Jan 19, 2025
@BlobbyBob
Copy link
Collaborator Author

Also, there are some translations not applying to all (future) instances, e.g. "searchDialog.infoMessage": "Wie Du sicher merkst, ist die Qualität der Suchfunktion gerade noch nicht sehr gut. Für das Hosting einer richtigen Suchmaschine fehlen uns gerade finanzielle Mittel. Werde Vereinsmitglied um dies zu ändern!",

It would probably be better to move such messages into the instance settings or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore refactoring Refactor existing code to make it better
Projects
None yet
Development

No branches or pull requests

1 participant