Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications are silently ignored if not also defined in app-notifications-service #577

Open
dorthrithil opened this issue Feb 9, 2025 · 0 comments
Labels
bug Something isn't working refactoring Refactor existing code to make it better
Milestone

Comments

@dorthrithil
Copy link
Contributor

This:

toastNotification(
  NotificationIdentifier.INSTANCE_SETTINGS_ERROR_MIGRATION_IMPOSSIBLE,
)

will do nothing, if the key is not defined in the notifications service. It should at least throw an error.

But a better way is to refactor this construct, so we don't have the enum and the map in some de-coupled files.

@dorthrithil dorthrithil added bug Something isn't working refactoring Refactor existing code to make it better labels Feb 9, 2025
@dorthrithil dorthrithil added this to the Candidates milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring Refactor existing code to make it better
Projects
None yet
Development

No branches or pull requests

1 participant