-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working #65
Comments
It absolutely does. Make sure you're downloading the actual built release at https://github.com/Log1x/acf-editor-palette/releases/tag/v1.2.0 (e.g. In the future, try to include more information when posting issues. |
Well it does not work. There for here is a fix: #66 |
You're going to have to provide more info then. When does the exception occur? Is this during validation? Your stack trace is hinting towards it. Perhaps something popping up now that block validation works in ACF Pro? How are you configuring your theme's editor palette? Does your PR actually fix this and otherwise work as intended? The palette is already casted to an array as well as checked if empty– the existing null coalescing should seemingly be fine. I'm sorry for closing this immediately, but your original issue gave absolutely zero details and this plugin has seen a good amount of installs/usage to not have any prior reports. |
This happens when trying to edit a page. Everything worked prior to 8.3 php. And yes I've tried in clients system with the fix and it works correctly. So aka, if I want to edit a page and the page has blocks that use palette. So when clicking on edit button for page in wp-admin redirects you to guthenberg editor. In this case it just throws error. I thought that too, that the casts and ?? null check should be working but php 8.3 is amazing at not letting anything trough. Is ok, sorry for bad message. It's monday and I'm just tired :D |
Seems that it does not work with latest wordpress & php versions...
The text was updated successfully, but these errors were encountered: