Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check-spelling usage (OSOE-961) #936

Closed
5 tasks done
Piedone opened this issue Jan 9, 2025 · 0 comments · Fixed by #972
Closed
5 tasks done

Remove check-spelling usage (OSOE-961) #936

Piedone opened this issue Jan 9, 2025 · 0 comments · Fixed by #972
Assignees
@Piedone

Comments

@Piedone
Copy link
Member

Piedone commented Jan 9, 2025 •
edited
Loading

If the result of Lombiq/GitHub-Actions#423 is that codespell is better, then let's remove check-spelling.

  • Remove the Spelling job from the Build and Test workflow.
  • Remove any config overrides in .github/actions/spelling and their solution file references.
  • Remove "#spell-check-ignore-line" from all projects, including submodules (also LGHA and PowerShell Analyzers).
  • Remove the spelling-this-repo workflow from Lombiq GitHub Actions.
  • Add a deprecation notice to SpellChecking.md, pointing people to use the codespell workflow isntead, and make the workflow display a ::warning with the same.

Jira issue
@github-actions github-actions bot changed the title Remove check-spelling usage Remove check-spelling usage (OSOE-961) Jan 9, 2025
@github-actions github-actions bot mentioned this issue Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Piedone Piedone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OSOE-961: Remove check-spelling usage Lombiq/Open-Source-Orchard-Core-Extensions
1 participant
@Piedone