Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Show CallerID on incoming call - Provider Sipgate #280

Open
Cyborgscode opened this issue Jun 7, 2022 · 7 comments
Open

Bug: Show CallerID on incoming call - Provider Sipgate #280

Cyborgscode opened this issue Jun 7, 2022 · 7 comments
Labels
external The source of this issue lies outside of the Twinkle codebase info needed SIP/SDP

Comments

@Cyborgscode
Copy link

Cyborgscode commented Jun 7, 2022

Setup: working Sipgate profile

If a call comes in via Sipgate, instead of the CallerID, the phonenumber of the connected sipgate account is shown. CallerID means here phone number of the (unkown) caller.

As JITSI does correctly shows the CallerID and the accounts phonenumber ( for whatever reason ), I tend to think it's a bug.

@fbriere
Copy link
Collaborator

fbriere commented Jun 9, 2022

Since I'm not familiar with sipgate, could you provide us with an example of what the SIP From header of an incoming call looks like (it will be in the Twinkle log, as part of the received INVITE message), as well as what you believe should be displayed instead?

For example, here's what it looks like for me:

From: "18195551212" <sip:[email protected]>;tag=m5UjyQ6ZayaaH

(Feel free to anonymize the phone number and IP address like I did.)

@Cyborgscode
Copy link
Author

From: "OWN SIPGATENUMBER" sip:[email protected];tag=as6d109891

@Cyborgscode
Copy link
Author

I think it's a sipgate bug.

the own sipgate number should send via TO: and not via FROM: , correct?

@Cyborgscode
Copy link
Author

I opened a Bugreport at Sipgate for this. I suggest to compensate for this Problem, if the own number is detected, the <sip:... @sipgate> Info should be shown together with the called number.

@fbriere fbriere added the external The source of this issue lies outside of the Twinkle codebase label Jun 13, 2022
@fbriere
Copy link
Collaborator

fbriere commented Jun 13, 2022

From: "OWN SIPGATENUMBER" sip:[email protected];tag=as6d109891

Then where does Jitsi find the "correct" number?

Could you paste the whole INVITE message? The answer has to be in there. (Again, anonymize appropriately, but make sure it is obvious to tell which number is your own and which is the caller.)

@Cyborgscode
Copy link
Author

ANSWERE from SIPGATE:

Simple form: "We know about the issue, but several customers want this behaviour to react on the number call ( they mean Callcenters ). It's fixable in the extended prefs for the phoneline options inside the sipgates website. "

WORKAROUND: ( i'm translating free from german to english here)

log into sipgate
find "my phones" ( top bar, left of the logout button )
"PHONE MANAGEMENT"
find the phone number you wanna change,
right to it is hamburger menu with "extended prefs" , click there
enable option "DISPLAY FOR SINGLE-LINE-DISPLAYs"

done.

@Cyborgscode
Copy link
Author

The answere my be worth added to the FAQ section of Twinkle.

It's up to you to detect the sipgate "bug" by comparing the number of the line, with the FROM field of the sip header
and just display the user-part and/or display the From: "name" + the userpart as two-line-displays would ( like Jitsi did ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external The source of this issue lies outside of the Twinkle codebase info needed SIP/SDP
Projects
None yet
Development

No branches or pull requests

2 participants