-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
페이지 상단 바(TopBar) 컴포넌트 구현 #186
Merged
Merged
+80
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyosin-Jang
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SungHyun627
현님 코드가 정말 깔끔하고 직관적으로 작성되어 있네요! 코드들이 잘 정리되어 있어서 읽는 데 전혀 어려움이 없었습니다 👍
아래 링크에도 남겨놨는데 저희가 페이지마다 wrapper 요소의 이름을 다르게 짓고 있어서 혹시 통일해보는 건 어떨까요?
#193 (review)
abiriadev
requested changes
May 14, 2024
필요한 기능을 잘 수행하는 컴포넌트를 만드신 것 같습니다! 특히 navigation을 잘 활용하신 것 같습니다. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 다음 이슈를 해결했어요.
💡 이슈를 처리하면서 추가된 코드가 있어요.
🛠 뒤로 가기 버튼 클릭 시, 이전 페이지로 이동하는 기능 구현
react-router-dom의 navigate를 이용하여, 뒤로 가기 버튼을 통해 이전 페이지로 이동하도록 구현했습니다.
🎬 이전 페이지로 이동
✔︎ TopBar 컴포넌트
💡 필요한 후속작업이 있어요.
✅ 셀프 체크리스트