Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloaded .subscribe inference #10

Open
KadekM opened this issue Nov 22, 2016 · 5 comments
Open

Overloaded .subscribe inference #10

KadekM opened this issue Nov 22, 2016 · 5 comments

Comments

@KadekM
Copy link
Contributor

KadekM commented Nov 22, 2016

There is what I believe same inference problem as in #6 with subscribe method, which is very unfortunace... Can we do do something about it ?

@LukaJCB
Copy link
Owner

LukaJCB commented Nov 22, 2016

Which of the two subscribe signatures do you think is more important? The apply function if the Observable class has the onNext as it's apply function if that helps.

@KadekM
Copy link
Contributor Author

KadekM commented Nov 22, 2016

Both are important :/
it's shame scala's not good with overloaded methods

@KadekM
Copy link
Contributor Author

KadekM commented Nov 22, 2016

We don't have to solve it right away - I don't know what's best way to go about it (since my guess is it's gonna be problem in most overloaded methods)... but we can keep the issue open to recognize limitations

@LukaJCB
Copy link
Owner

LukaJCB commented Nov 22, 2016

Yeah, unfortunately the original RxScala api suffers from the same problems. We could create extra functions instead of overloads, but I don't want to strain to far from the original API.

@KadekM
Copy link
Contributor Author

KadekM commented Nov 22, 2016

Yea, straining from api is my biggest worry. That would just bring gap to newcomers trying to use typed rx with scala.js... but so will different naming =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants