Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe unlock advancement broken forever #80

Open
superon opened this issue Aug 13, 2024 · 2 comments
Open

recipe unlock advancement broken forever #80

superon opened this issue Aug 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@superon
Copy link

superon commented Aug 13, 2024

Describe the bug
the recipe/s is/are unlocked when you join a world rather than when it should be

To Reproduce
start a world and view recipes in the recipe book

Expected behaviour
the recipe should stay unlocked until the requisite items have been discovered

Additional context
this seems to be in every version going back to 1.16.5 and can be easily fixed by replacing the condition "items" with the singular "item" afiak.
ie:
glow_painting.json

@superon superon added the bug Something isn't working label Aug 13, 2024
@Luke100000
Copy link
Owner

It only affects 1.16.5; the syntax has changed:

      "conditions": {
        "items": [
          {
            "item": "minecraft:paper"
          }
        ]
      }

Thanks for reporting.

@superon
Copy link
Author

superon commented Aug 13, 2024

ahha np

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants