Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator-generated.php seems to be incomplete #208

Open
mxhCodes opened this issue Nov 21, 2017 · 1 comment
Open

validator-generated.php seems to be incomplete #208

mxhCodes opened this issue Nov 21, 2017 · 1 comment

Comments

@mxhCodes
Copy link

The specification is either out of date or incomplete.
Example:
amp-accordion has the attribute disable-session-states specified.

https://www.ampproject.org/docs/reference/components/amp-accordion

When using this attribute with this library, the validator will filter it out as it's not included as a specified attribute in validator-generated.php

Please check if you need to rebuild this file or whether the canonical validator itself might miss this specification.
@marcelovani
Copy link

The validator needs update, see #231

@marcelovani marcelovani mentioned this issue Dec 7, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelovani @mxhCodes