Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Sharing via SymLinks instead of Junctions? #991

Open
richardm1 opened this issue Nov 9, 2024 · 2 comments
Open

Model Sharing via SymLinks instead of Junctions? #991

richardm1 opened this issue Nov 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@richardm1
Copy link

What happened?

I've used Select new Models Folder to move my models to a network share.

The "symlink" models sharing option (in the ComfyUI package three-dots menu) actually creates directory junctions rather than symbolic links which can refer to local volumes but not network drives. The junctions are created successfully but they're inoperative:

OSError: [WinError 4392] The data present in the reparse point buffer is invalid: 'D:\\SM\\Data\\Packages\\ComfyUI\\models\\controlnet\\ControlNet'

I believe symlinks would work for referencing network drives and could potentially replace directory junctions altogether for use within SM. Unfortunately the creation of symlinks requires administrator rights unless the system's local security policy has been modified to permit ordinary users.

I'm happy to help test any ideas for working around this issue.

Steps to reproduce

  1. Relocate Models folder to a network share.
  2. Change Models location with SM configuration -- relaunch.
  3. Configure ComfyUI package for "symlink" style model sharing.
  4. Launch ComfyUI -- observe OSError: [WinError 4392] The data present in the reparse point buffer is invalid

Relevant logs

SM logs only show `Failed to connect to Inference backend|Refit.ApiException: Response status code does not indicate success: 500 (Internal Server Error)` due to ComfyUI not starting successfully.

Version

2.13.0-dev.3+f5113af

What Operating System are you using?

Windows

@richardm1 richardm1 added the bug Something isn't working label Nov 9, 2024
@mohnjiles
Copy link
Contributor

Unfortunately the creation of symlinks requires administrator rights unless the system's local security policy has been modified to permit ordinary users.

This is the main reason we went with junctions on Windows instead of symlinks, though we could maybe add an option to switch it in the settings with an admin notice & whatnot.

In the meantime, does the "Config" model sharing option work?

@richardm1
Copy link
Author

In the meantime, does the "Config" model sharing option work?

It seems to work fine but I've only used the built-in inferencer+Comfy. I've yet to try it with any other packages.

To your knowledge does the "config" option work just as well as "symlink" for the average user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants