Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch formatter from Black to Blue? #96

Open
smoia opened this issue Apr 26, 2024 · 2 comments
Open

Switch formatter from Black to Blue? #96

smoia opened this issue Apr 26, 2024 · 2 comments
Labels
Enhancement New feature or request Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog

Comments

@smoia
Copy link
Collaborator

smoia commented Apr 26, 2024

@miki998 @mscheltienne would you be ok with switching formatter from Black to Blue?

The double quote always irritated me 😅

Also, @mscheltienne, if ruff supports isort, shouldn't we just use ruff for everything?

@smoia smoia added Enhancement New feature or request Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog labels Apr 26, 2024
@mscheltienne
Copy link
Collaborator

I prefer black to blue personally, but it's a matter of personal taste. As you want, no strong feelings either way.
If the quotes are the only irritating part, you can set this single rule in the configuration with:

[tool.ruff.format]
quote-style = "single"

if ruff supports isort, shouldn't we just use ruff for everything?

That's the idea, but I haven't configured it yet for isort on my templates/projects. If you have the time, feel free :)

@miki998
Copy link
Collaborator

miki998 commented Apr 26, 2024

I don't mind 'black' and so if we can set the quotation in configuration then we could try to do that instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog
Projects
None yet
Development

No branches or pull requests

3 participants