Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recommonmark is no longer supported #1314

Open
s-t-e-v-e-n-k opened this issue Jan 15, 2025 · 2 comments
Open

recommonmark is no longer supported #1314

s-t-e-v-e-n-k opened this issue Jan 15, 2025 · 2 comments

Comments

@s-t-e-v-e-n-k
Copy link

As mentioned at readthedocs/recommonmark#221 , recommonmark (and CommonMark) are no longer supported, and users are strongly encouraged to move to myst-parser. I'm happy to push up a PR doing so, but wanted an issue filed first to see if there are any objections or other ideas.
@Rafiot
Copy link
Member

Rafiot commented Jan 15, 2025

sure, go for it. I'm not sure it is used at all, but if you already have a PR ready, I'll happily merge it.

@s-t-e-v-e-n-k
Copy link
Author

It's still pulled in by the docs build, but you're probably right that we can just remove that bit entirely.

s-t-e-v-e-n-k added a commit to s-t-e-v-e-n-k/PyMISP that referenced this issue Jan 16, 2025
@s-t-e-v-e-n-k
Drop use of recommonmark
7d06e52 
recommonmark has been deprecated and archived upstream since early 2022,
and appears to be unused, so stop installing and calling it.

Fixes MISP#1314
@s-t-e-v-e-n-k s-t-e-v-e-n-k mentioned this issue Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop use of recommonmark s-t-e-v-e-n-k/PyMISP
2 participants
@Rafiot @s-t-e-v-e-n-k