Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide alternative SendGazeReportXX() method without timestamp #3

Closed
jatinsha opened this issue Mar 5, 2021 · 3 comments
Closed
Assignees

Comments

@jatinsha
Copy link

jatinsha commented Mar 5, 2021

SendGazeReportUm(long X, long Y, unsigned long long timestamp);
SendGazeReportPixel(long X, long Y, unsigned long long timestamp);

The current SendGazeReportXX methods expect timestamp to be supplied by the user. In certain scenarios, the user may not have timestamps and should be able to use the API where the API itself calculates the timestamps internally.

@jatinsha
Copy link
Author

jatinsha commented Mar 5, 2021

I am assuming that the timestamp is in milliseconds but it would be good to have a short description (or a more descriptive name) that tells whether it is relative or from epoch. E.g. timestamp_ms_from_epoch, timestamp_ms_relative etc.

@joncamp
Copy link
Contributor

joncamp commented Mar 5, 2021

image
Good point, clarity would definitely help in this case. in reality I believe under the covers it is mostly ignored as long as it is positive and increasing, but we should do the right thing.

@joncamp
Copy link
Contributor

joncamp commented May 13, 2021

Sending 0 will automatically generate a timestamp.

@joncamp joncamp closed this as completed May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants