We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I remember it was not so, but multiple symbols are broadcasted weirdly at some point.
When I set some symbols in a calendar like this;
symbol: ["file", "calendar"],
The expected broadcasted data(And the historical format what I remember) would be like this; (with defaultSymbolClassName)
defaultSymbolClassName
symbol: ["fa fa-fw fa-file", "fa fa-fw fa-calendar"], // Array(2)
Bur really broadcasted would be;
symbol: ["fa fa-fw fa-file, fa fa-fw fa-calendar"], // Array(1)
Is this intentionally designed so? Or just an unexpected accident?
The text was updated successfully, but these errors were encountered:
Thanks for the report (and sorry for the late replay). Can you pinpoint when this behaviour changed?
Sorry, something went wrong.
I am fixing things in calendar now.. @eouia can u answer @rejas
I see the bug, checking on how to fix
so, here is my proposed change
getCalendarPropertyAsArray (url, property, defaultValue) { let p = this.getCalendarProperty(url, property, defaultValue); if (property === "symbol" || property === "recurringSymbol" || property === "fullDaySymbol") { const className = this.getCalendarProperty(url, "symbolClassName", this.config.defaultSymbolClassName); if(p instanceof Array) // add p.push(className) // add else // add p = className + p; // old code assumed property was string } if (!(p instanceof Array)) p = [p]; return p; },
sdetweil
No branches or pull requests
I remember it was not so, but multiple symbols are broadcasted weirdly at some point.
When I set some symbols in a calendar like this;
The expected broadcasted data(And the historical format what I remember) would be like this; (with
defaultSymbolClassName
)Bur really broadcasted would be;
Is this intentionally designed so? Or just an unexpected accident?
The text was updated successfully, but these errors were encountered: