Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Weather module] Zeros are no longer hidden in forecast #3572

Open
CGabo opened this issue Oct 1, 2024 · 6 comments
Open

[Weather module] Zeros are no longer hidden in forecast #3572

CGabo opened this issue Oct 1, 2024 · 6 comments

Comments

@CGabo
Copy link

CGabo commented Oct 1, 2024

Hi

In the newer release of MM Weather Module (forecast), the zeros are no longer hidden.

Version: 2.24.0: If the value is zero, it will be hidden aka blanked out.

Version: 2.29.0: All numbers are displayed, including the zeros

Maybe this was changed in the previous version, I can't say because I skipped some versions.
But the old version looked nicer when the zeros were not displayed.

See please the picture.

MagicMirror-zeros-hide-hourly-forecast

Is it possible to bring it back or maybe there could be an option in the config?

Thank you so much for your great job!
Have a nice day.

@CGabo
Copy link
Author

CGabo commented Oct 1, 2024

Please see also:
Precipitation Probability not displayed when it is 0% #3345

This was changed in Release 2.27.0 #3410, but as I mentioned, I mean the 0 mm, not the 0%
Thanks

@khassel
Copy link
Collaborator

khassel commented Oct 1, 2024

thank you for the research. You want it not displayed, the one who opened the old issue wants to see 0 values ...

So only way I see is to add a param ...

@CGabo
Copy link
Author

CGabo commented Oct 1, 2024

Yes that would be great!
Maybe the change could be included in a future release?

Honestly, which representation is better?
From a distance, you can see that there is no rain.
Even if the probability tends towards zero ;-)

Thanks again
Gabo

@khassel
Copy link
Collaborator

khassel commented Oct 1, 2024

Honestly, which representation is better?

that's a matter of taste ... I agree with you and prefer empty values.

Maybe the change could be included in a future release?

the next release is in 3 months, feel free to implement it ;) (otherwise I will do it at some point)

@CGabo
Copy link
Author

CGabo commented Oct 2, 2024

Ok, I give it a try.
Should I leave it open until I implemented the change?

@khassel
Copy link
Collaborator

khassel commented Oct 2, 2024

Ok, I give it a try.

👍

Should I leave it open until I implemented the change?

yes, please.

Procedure is:

  • issue is solved by a PR and merged on develop branch
  • with next release develop is merged on master and we close all solved issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants